add temporal worker deployment create-version#971
add temporal worker deployment create-version#971jaypipes wants to merge 1 commit intotemporalio:serverlessfrom
temporal worker deployment create-version#971Conversation
|
|
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
4dded90 to
765f4f8
Compare
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
765f4f8 to
935a0d6
Compare
Adds implementation of the `temporal worker deployment create-version` CLI command using only direct gRPC API calls, not the sdk-go client code. TODO: add unit tests. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
935a0d6 to
aa347d3
Compare
Generally it'd be great to have tests coverage that matches existing coverage for worker deployments. IIRC there's some tests that hit the dev server. |
| case "nexus": | ||
| return enumspb.TASK_QUEUE_TYPE_NEXUS | ||
| default: | ||
| return enumspb.TASK_QUEUE_TYPE_UNSPECIFIED |
There was a problem hiding this comment.
any reason that this shouldn't error if there isn't a match? case "" seems more appropriate for unspecified
you could use this generic. not blocking though
There was a problem hiding this comment.
nice. didn't know about that :) will update shortly!
| return "activity" | ||
| case enumspb.TASK_QUEUE_TYPE_NEXUS: | ||
| return "nexus" | ||
| default: |
There was a problem hiding this comment.
would be great if this could be a generic as well.
There was a problem hiding this comment.
removed this and using the existing taskQueueTypeToStr() defined above.
| go.temporal.io/api v1.62.3-0.20260327234204-dbc016f3811d | ||
| go.temporal.io/sdk v1.41.1-0.20260310224809-feecdd6377fc |
There was a problem hiding this comment.
you probably already know this but we need tagged dependencies for this to merge to main.
BUT you can use cloud tags from temporalio/temporal for the dev server. We just have to change it to a oss tag before we release from main
| // ScalingGroups contains the set of ComputeConfigScalingGroup objects | ||
| // associated with the ComputeConfig. The key for the map is the ID of the | ||
| // scaling group. | ||
| ScalingGroups map[string]*computeConfigScalingGroup |
There was a problem hiding this comment.
why map[string]*computeConfigScalingGroup and not map[string]computeConfigScalingGroup?
|
CI failures seem relevant to this change. |
| Scaler: &computeScaler{ | ||
| // NOTE(jaypipes): Hard-coding the no-sync scaling | ||
| // algorithm since as of April 1, 2026, this is the only | ||
| // supported one in temporal-auto-scaled-workers. | ||
| Type: "no-sync", | ||
| }, |
There was a problem hiding this comment.
you don't even need to set the scaler config - there is a default config deduced from the provider to avoid this.
There was a problem hiding this comment.
I'm keeping this in for now just to make it more explicit (especially since we will shortly support different scaling algorithms and options...)
4 participants
Adds implementation of the
temporal worker deployment create-versionCLI command using only direct gRPC API calls, not the sdk-go client code.TODO: add unit tests.